Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improper visual node content in SetProperty / SetProperties #2936

Merged
merged 1 commit into from
May 7, 2020
Merged

fix: improper visual node content in SetProperty / SetProperties #2936

merged 1 commit into from
May 7, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented May 7, 2020 •
edited
Loading

Description

fixes #2877 incorrect SetProperty content in visual nodes

Problems in Visual node:

  1. If value set to false or 0, SetProperty shows ? instead of real value
  2. Content in SetProperty and SetProperties are not consistent.

Changes:

  1. Let SetProperty and SetProperties share the same component <PropertyAssignment>
  2. Update Flow Editor schema.

Preview:

image

Task Item

Screenshots

@yeze322 yeze322 mentioned this pull request May 7, 2020
Closed
1 task
@github-actions
Copy link

github-actions bot commented May 7, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 1997f86 on visual/setprop into 398dbdf on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 57d9e53 into master May 7, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the visual/setprop branch May 7, 2020 15:16
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322
fix: improper visual node content in SetProperty / SetProperties (mic…
7f90dfe 
…rosoft#2936)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeze322 @a-b-r-o-w-n