feat: package and schema update for 4.9.0-RC4 #2911

luhan2017 · 2020-05-06T07:32:12Z

Description

Update sdk packages and schema for 4.9.0-RC1 which include following major changes:

Schema updates:

OnCustomEvent is removed, we can use OnDialogEvent for cusmized event, we also need to update the trigger wizard @liweitian
Add SkillDialog.connectionName in schema. This is to help expose the skillDialog OAuth step to the caller. @luhan2017 will follow up on the usage and docs.
Add RepeatDialog.Allowloop.
dialog:merge tool updated with some new schema features such as role extend which removed allof and removed $copy and $id...

Runtime updates:

explicitly add Qna reference in csproj, which will fix the qna schema missing issue.
add component registration part in startup.cs.
OAuthInput fix for skill mode.

Task Item

fixes #2878
fixes #2942

Screenshots

github-actions · 2020-05-06T07:41:02Z

Coverage remained the same at 0.0% when pulling 563261c on luhan/rc1 into 70b9715 on master.

luhan2017 · 2020-05-06T13:31:36Z

@a-b-r-o-w-n In this latest schema, the BeginDialog.options is changed to "$ref": "#/definitions/objectExpression",

which will affect the form ux like this:

cwhitten · 2020-05-06T14:21:26Z

@luhan2017 why can't dialog:merge discover the QnAMaker component schema?

a-b-r-o-w-n · 2020-05-06T21:49:37Z

@luhan2017 @liweitian I believe I have updated everything needed, including the trigger creation modal. Please confirm.

luhan2017 · 2020-05-07T10:32:52Z

I've tested this and found some issues:
1, Send A response

Recognizer
SetProperties

I' am wondering if there is anything wrong with my local environment, I will double check in my laptop soon.

a-b-r-o-w-n · 2020-05-07T15:04:44Z

I will take a look ASAP.

a-b-r-o-w-n · 2020-05-07T18:18:49Z

@luhan2017 I have updated to the rc4 and updated the schema. There is currently an issue building the dotnet app though that maybe you can take a look at today.

a-b-r-o-w-n · 2020-05-07T22:03:16Z

@luhan2017 I took a stab at correcting the build failure (due to microsoft/botbuilder-dotnet@08590f9) with the help of @lauren-mills

…ecause it is no longer valid

luhan2017 · 2020-05-08T05:42:51Z

I've tested all the templates, they all work well. so we are ready for review on this.

beyackle · 2020-05-08T15:45:23Z

Composer/cypress/integration/NotificationPage.spec.ts

@@ -49,7 +49,7 @@ context('Notification Page', () => {
    cy.findAllByText('__TestToDoBotWithLuisSample').should('exist');
  });

-  it('can show dialog expression error ', () => {
+  it.skip('can show dialog expression error ', () => {


Did you mean to leave this test skipped?

Yes. Expression validation is broken currently. We decided not to block the PR and do a follow up bug fix.

beyackle · 2020-05-08T15:57:32Z

scripts/generate-sdk-enum.js

+const types = Object.keys(schema.definitions).reduce((all, defName) => {
+
+  if (defName.startsWith('Microsoft.') && !defName.startsWith('Microsoft.Test')) {
+    all.push(defName);
+  }
+
+  return all;
+}, []);


I won't block this PR on it, but I think this could be written more easily with a .filter.

That's a good suggestion. Since this is already merged, I'll probably leave as is.

* package and schema update for 4.9-RC1 * update trigger wizard (microsoft#2917) * rename variable * update SDKKinds enum * fix references to removed kinds * fix schema resolution for property editor * do not title case the schema title * add ability to type custom event name in trigger creation * fix autoEndDialog type in samples * generate sdk enum with all definitions * Revert changes to ui schema and label map * update ActivityTemplate to IActivityTemplate for lg fields * resolve schema in order to determine stacking * remove test types from sdk enum * fix failing tests * skip failing test * update sdk packages and schema to rc4 * update bot start up to not use HostContext * Update some enum to lower case and removed the recognizerset sample because it is no longer valid * update deprecated method Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

package and schema update for 4.9-RC1

563261c

luhan2017 requested review from a-b-r-o-w-n, benbrown, beyackle, boydc2014, carlosscastro, corinagum, cwhitten, srinaath and tonyanziano as code owners May 6, 2020 07:32

luhan2017 changed the title ~~package and schema update for 4.9.0-RC1~~ feat: package and schema update for 4.9.0-RC1 May 6, 2020

a-b-r-o-w-n self-assigned this May 6, 2020

a-b-r-o-w-n marked this pull request as draft May 6, 2020 15:03

liweitian and others added 10 commits May 6, 2020 09:21

update trigger wizard (#2917)

297109e

rename variable

1a9a441

update SDKKinds enum

b6718f6

Merge branch 'master' into luhan/rc1

582c747

fix references to removed kinds

7043b27

fix schema resolution for property editor

0eade59

do not title case the schema title

c0bc0c0

add ability to type custom event name in trigger creation

b86095e

fix autoEndDialog type in samples

5131529

Merge branch 'master' into luhan/rc1

4953447

a-b-r-o-w-n marked this pull request as ready for review May 6, 2020 21:48

Merge branch 'master' into luhan/rc1

a1a937d

a-b-r-o-w-n added 9 commits May 7, 2020 08:17

Merge branch 'master' into luhan/rc1

2751521

generate sdk enum with all definitions

a0598ce

Revert changes to ui schema and label map

10b586b

update ActivityTemplate to IActivityTemplate for lg fields

2161c06

resolve schema in order to determine stacking

8f3a944

remove test types from sdk enum

eda700b

fix failing tests

16fc327

skip failing test

36bec81

update sdk packages and schema to rc4

bf31082

a-b-r-o-w-n changed the title ~~feat: package and schema update for 4.9.0-RC1~~ feat: package and schema update for 4.9.0-RC4 May 7, 2020

Merge branch 'master' into luhan/rc1

04eea0c

a-b-r-o-w-n marked this pull request as draft May 7, 2020 20:33

a-b-r-o-w-n added 2 commits May 7, 2020 14:46

update bot start up to not use HostContext

3eb8df1

Merge branch 'master' into luhan/rc1

494e6ff

Update some enum to lower case and removed the recognizerset sample b…

87cd210

…ecause it is no longer valid

luhan2017 marked this pull request as ready for review May 8, 2020 05:42

a-b-r-o-w-n and others added 3 commits May 8, 2020 08:17

Merge branch 'master' into luhan/rc1

c2772e4

update deprecated method

f65ecec

Merge branch 'master' into luhan/rc1

6c1e448

cwhitten approved these changes May 8, 2020

View reviewed changes

cwhitten merged commit cc66deb into master May 8, 2020

beyackle reviewed May 8, 2020

View reviewed changes

This was referenced May 11, 2020

Unable to find the Custom event and Message events triggers... #2988

Closed

release: prepare release notes #3096

Merged

a-b-r-o-w-n deleted the luhan/rc1 branch May 18, 2020 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: package and schema update for 4.9.0-RC4 #2911

feat: package and schema update for 4.9.0-RC4 #2911

luhan2017 commented May 6, 2020 •

edited by a-b-r-o-w-n

Loading

github-actions bot commented May 6, 2020

luhan2017 commented May 6, 2020

cwhitten commented May 6, 2020

a-b-r-o-w-n commented May 6, 2020

luhan2017 commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

luhan2017 commented May 8, 2020

beyackle May 8, 2020

a-b-r-o-w-n May 8, 2020

beyackle May 8, 2020

a-b-r-o-w-n May 8, 2020

feat: package and schema update for 4.9.0-RC4 #2911

feat: package and schema update for 4.9.0-RC4 #2911

Conversation

luhan2017 commented May 6, 2020 • edited by a-b-r-o-w-n Loading

Description

Task Item

Screenshots

github-actions bot commented May 6, 2020

luhan2017 commented May 6, 2020

cwhitten commented May 6, 2020

a-b-r-o-w-n commented May 6, 2020

luhan2017 commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

a-b-r-o-w-n commented May 7, 2020

luhan2017 commented May 8, 2020

beyackle May 8, 2020

Choose a reason for hiding this comment

a-b-r-o-w-n May 8, 2020

Choose a reason for hiding this comment

beyackle May 8, 2020

Choose a reason for hiding this comment

a-b-r-o-w-n May 8, 2020

Choose a reason for hiding this comment

luhan2017 commented May 6, 2020 •

edited by a-b-r-o-w-n

Loading