fix: bot content not updating after restart #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `child_process.kill()` will kill that process but does not kill all processes spawned by that process. We need to run the bot in a detached process which gets its own process group, then call `process.kill(-child.pid)` to kill all porcesses in that group.
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
May 1, 2020
|
This is not compatible in windows, see nodejs/node#3617. Also, using detached = true is causing the process.on('data') can't get fired, and thus the resolve is never called, so the request never finished. I didn't see this dotnet run process is creating sub-processes, is it creating sub processes in Mac? |
This was referenced May 3, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1747
Description
Calling
child_process.kill()will kill that process but does not kill all processes spawned by that process. We need to run the bot in a detached process which gets its own process group, then callprocess.kill(-child.pid)to kill all porcesses in that group.Task Item
Screenshots