fix: unexpected file changes when editing #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum and
cwhitten
as code owners
|
Nowadays, client handle most changes in local, so after first load, we also do not need server index anymore. |
zhixzhan
changed the title
…mposer into open-project-fix
zhixzhan
commented
Apr 28, 2020
zhixzhan
commented
Apr 28, 2020
zhixzhan
commented
Apr 28, 2020
zhixzhan
commented
Apr 28, 2020
zhixzhan
commented
Apr 28, 2020
zhixzhan
commented
Apr 28, 2020
a-b-r-o-w-n
approved these changes
Apr 30, 2020
7 tasks
Note for a special case.If some changes are made in current opened bot , not via Composer, e.g delete a dialog from local file system, the Composer wouldn't receive this changes. Cause this PR let Composer server use indexed project. To make Composer sync with external file change, user need to re-open current project force trigger a server index. |
This was referenced May 15, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* use cached projects * don't need to call init after project loaded * use a real-time refreshed files list, fix concurrency deletes * update test * create/saveAs/open project should call init * clean up * update Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #2748 is when editing, the concurrency bug in
reformatmethodsAfter some refactor by plugins PR #2023, getProjectById is called at very high frequency. And every getProjectById() --> Project.index() , and inside it some
reformatmethods executed would travels all files do reformat. When called in concurrency it produced a write bug.By re-using an indexed project instead of call index() everytime we could avoid this type problem and improve performance.
Issue #2793 is when delete a dialog, the concurrency bug in
removeFilemethods.this.filesis not updated immediately.Task Item
close #2748
close #2793
Screenshots