Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: accessibility 2052 #2778

Merged
merged 5 commits into from
Apr 28, 2020
Merged

a11y: accessibility 2052 #2778

merged 5 commits into from
Apr 28, 2020

Conversation

liweitian
Copy link
Contributor

Description

Now after creating a new lg template, the narrator will focus on the new created item.

Task Item

Refs #2052

Screenshots

aaaa

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 175b08f on liweitian:accessibility2052-2 into 0ac036f on microsoft:master.

@cwhitten cwhitten requested a review from srinaath as a code owner April 27, 2020 20:14
@cwhitten
Copy link
Member

@liweitian I've noticed that the context menu on the left is not keyboard navigable. Can this be added to this change?

Screen Shot 2020-04-27 at 1 21 44 PM

cwhitten
cwhitten requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see earlier comment

@liweitian
Copy link
Contributor Author

liweitian commented Apr 28, 2020 •
edited
Loading

@liweitian I've noticed that the context menu on the left is not keyboard navigable. Can this be added to this change?

Screen Shot 2020-04-27 at 1 21 44 PM

aaaa
@cwhitten We are using DetailedList. The button is a cell of that table. By design of microsoft UI, we can only navigate to the row, then we can go inside of each row. This is already merged in master.

@cwhitten
Copy link
Member

got it, thank you @liweitian

@cwhitten cwhitten merged commit 843d639 into microsoft:master Apr 28, 2020
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@liweitian @cwhitten
focus on the last element after create a new lg Template (microsoft#2778
1ab4d15 
)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liweitian @cwhitten