feat: Update sdk schema #2729
feat: Update sdk schema #2729
Conversation
luhan2017
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
|
I'll make some PR's today to address those issues. |
| @@ -0,0 +1,2 @@ | |||
| cd .. | |||
| bf dialog:merge *.csproj -o schema/sdk.schema -v -b "R9" | |||
There was a problem hiding this comment.
"R9" [](start = 51, length = 5)
NO, this should be ""
This switch is going away, and you should not be passing data to it, except an empty string.
|
@luhan2017 update: I have been talking with @tomlm about make some more adjustments to the schema based on the usage by the property editor. He is in the process of applying those updates and I will push some commits into this branch. I have marked the PR as draft in the meantime. |
http request body is an expression now, so the expression plugin handles it
still need to pass in schema
|
|
The schema was based off of microsoft/botbuilder-dotnet#3794. That has been merged to we should take the nightly build to generate the schema. |
expression is now the default option
|
@luhan2017 I have fixed 1 failing e2e test. The other is due to the issue you mentioned above. Ping me when you update the schema to the nightly build and I will do another look and then we can merge. |
|
@a-b-r-o-w-n , I've updated to the very latest schema and packages, and I did some sanity test, the samples looks good now.
|
|
I've found another issue about the validation, I've talke with @lei9444 on this, he will submit a PR to fix the validation logic.
|
|
@luhan2017 can you address the conflicts as well as investigate the e2e test failure? Once those are addressed, go ahead and merge. |
* Update sdk schema * use dialog:merge to generate the schema * Update readme.md * Update * remove R9 * render select field for all enums, not just strings * merge parent schema into resolved schema for oneOf * enable dropdown option in OneOfField * handle new expression schema shapestill more to do * remove value field in prompts * show card action in choices form * allow oneOf schema to set placeholder * account for rows when checking to stack items * clean up choices form schema * remove json plugin http request body is an expression now, so the expression plugin handles it * render choice action as json editor still need to pass in schema * pass schema through json field * do not merge parent schema into oneOf * update lockfile * remove emit event plugin * if type is undefined, use string field * get enum options from oneOf schemas * enable fetching of schema * add recognizer options to prompt fields * fix issue passing errors in array items * stop-gap for blocking shell operation * update schema * fix jest config * allow for setting startup command for e2e * fix notification page spec expression is now the default option * Schema update * Update sdk.schema * remove the duplicate types for schema (microsoft#2782) Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
Description
Tom has a commit in the sdk side to go through and update the schema. I am bring that update in composer. (the package update is included in #2679 )
Here are two issues I found for the schema update, others looks good to me.
EditArray->changeType, HttpRequest->responseType. Here is one example:
Now:
Suggested Fix:
@cwhitten @a-b-r-o-w-n
Task Item
fixes #2541
closes #2743
Screenshots