Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: add home page elements to tab index #2665

Merged
merged 8 commits into from
Apr 16, 2020
Merged

Conversation

beyackle
Copy link
Contributor

Description

This updates our home page to fix a few small issues:

  • Elements are now all tab-able, with sensible labels
  • The list of recent bots behaves like the Open dialog, where cursoring into it doesn't automatically launch a bot
  • Some typos in the list of samples

Task Item

Closes #2011

Screenshots

image

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.02%) to 41.455% when pulling 2ffdf33 on beyackle/homePageTabs into 9f85a17 on master.

@corinagum
Copy link
Contributor

The nitty gritty details are my favorite. ♥

I believe these links also be in the natural tab order. When I check, they're skipped & focus goes to the Examples section:
image

@corinagum corinagum self-assigned this Apr 15, 2020
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the last tab index in my PR. disregard last comment :)

@corinagum corinagum merged commit c946700 into master Apr 16, 2020
@corinagum corinagum deleted the beyackle/homePageTabs branch April 16, 2020 22:14
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* a11y: add home page elements to tab index

* Update home.test.js

* Update home.test.js

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants