Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification error navigate #2561

Merged
merged 5 commits into from
Apr 9, 2020
Merged

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Apr 8, 2020

Description

Task Item

closes #2533
closes #2546

Screenshots

Untitled2

@cwhitten
Copy link
Member

cwhitten commented Apr 8, 2020

@zhixzhan why in the scenario of an inline LG error on a template like bdfactivity-23orinfe does the navigation take you to the all-up page? I thought the intention was to navigate to the action directly in this case of inline LG or LU errors. Was this behavior changed by design?

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Apr 9, 2020

@cwhitten By design it should navigate to inline, current not working come from 2 reason.

  1. after involved projectId &locale the url calculation did not been updated (fixed now)
  2. for some scenario of inline LU error ( maybe also LG in lower chance), our reverse calculate error's dialogPath rely on luParser can parse the error intent, so the error can be located in one intent, then the dialog use that this intent can be located, and calculate to a dialog path.

for 2 in conclusion, currently, not every inline error can be navigate back to inline editor because of our lg/lu Parser ability.

@cwhitten
Copy link
Member

cwhitten commented Apr 9, 2020

@cwhitten By design it should navigate to inline, current not working come from 2 reason.

  1. after involved projectId &locale the url calculation did not been updated (fixed now)

I just tried it out and didn't see any different in behavior with a LG error. It still navigated to the all-up page

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Apr 9, 2020

@cwhitten By design it should navigate to inline, current not working come from 2 reason.

  1. after involved projectId &locale the url calculation did not been updated (fixed now)

I just tried it out and didn't see any different in behavior with a LG error. It still navigated to the all-up page

can you paste the error lg file or bot, let me check again. if a LG error ( like just updated screenshot ) it did navigate to form editor

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Apr 9, 2020

@cwhitten updated, found another reason is lgNamePattern not updated from 'bdfactivity-233534' to 'bdfactivity-23orinfe'

Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cwhitten cwhitten merged commit d2d69f2 into microsoft:master Apr 9, 2020
@zhixzhan zhixzhan deleted the bugfix branch April 9, 2020 06:59
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* notification navigate fix with locale

* navigate with bot id

* update id calculate

* fix lgNamePattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants