Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: fix behavior of object-array fields #2407

Merged
merged 2 commits into from
Mar 27, 2020
Merged

a11y: fix behavior of object-array fields #2407

merged 2 commits into from
Mar 27, 2020

Conversation

beyackle
Copy link
Contributor

Description

This fixes the ObjectArrayField in two ways:

  • Adds aria labels with audible instructions, as per the issue
  • Sends focus back to the first field in a row when a new object is created instead of leaving it on the last one (just so the instructions aren't a lie)

Task Item

Closes #2130

Screenshots

image

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.03%) to 39.603% when pulling 3daa66d on beyackle/objectArrayFieldCaptions into 7e9da2a on master.

@beyackle beyackle merged commit 173809c into master Mar 27, 2020
@beyackle beyackle deleted the beyackle/objectArrayFieldCaptions branch March 27, 2020 21:52
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@beyackle @a-b-r-o-w-n
fix behavior of object-array fields (microsoft#2407)
33a59b4 
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beyackle @a-b-r-o-w-n