fix: Supporting suggest cards in inline LG editing #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicshuai
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
a-b-r-o-w-n
reviewed
Mar 26, 2020
| @@ -23,6 +23,7 @@ const defaultOptions: monacoEditor.editor.IEditorConstructionOptions = { | |||
| glyphMargin: false, | |||
| folding: false, | |||
| renderLineHighlight: 'none', | |||
| formatOnType: true, | |||
There was a problem hiding this comment.
Let's make sure this doesn't cause weirdness in the other places that the code-editor is used.
There was a problem hiding this comment.
Let's make sure this doesn't cause weirdness in the other places that the code-editor is used.
I tested the editors in composer. Only the LG editor will have the ability to format structure lg input.
There was a problem hiding this comment.
thanks for investigating @cosmicshuai
cwhitten
approved these changes
Mar 27, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2330
Now card suggestion are enabled in inline LG.
Also, formating of auto complete is improved. The indent before ending '[' will be deleted automatically.