a11y: have screen-reader extract card titles from headers #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten and
yeze322
as code owners
corinagum
reviewed
Mar 25, 2020
Composer/packages/extensions/visual-designer/src/components/renderers/ElementWrapper.tsx
Show resolved
Hide resolved
|
LGTM :) |
cwhitten
approved these changes
Mar 25, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…2367) * read action-header titles in SR * add titleInHeader prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The label that gets read by the screen reader turns out to come from the ElementWrapper component, so this adds some mechanisms to that code so it can reach in and extract the title of what it's rendering. I couldn't use a callback because ElementWrapper just has generic "children" with no guarantee of that having any shape in particular, and I didn't want to add a whole new "ariaLabel" field to our schema when it would just duplicate the same information already in "title".
There are a lot more screen-reader-related issues going on in this codebase, but this at least fixes one of them.
Task Item
Closes #2058