Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visual Editor] SetProperties does not correctly display object types #2309

Closed
a-b-r-o-w-n opened this issue Mar 19, 2020 · 4 comments
Closed

[Visual Editor] SetProperties does not correctly display object types #2309

a-b-r-o-w-n opened this issue Mar 19, 2020 · 4 comments
Assignees
@alanlong9278 @yeze322
Labels
R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working

Comments

@a-b-r-o-w-n
Copy link
Contributor

image
@a-b-r-o-w-n a-b-r-o-w-n added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Mar 19, 2020
@hibrenda hibrenda removed the Needs-triage A new issue that require triage label Mar 19, 2020
@yeze322
Copy link
Contributor

yeze322 commented Mar 20, 2020

What's our expected appearance of an object?
To show its full value or just tell user it's an Object [Object]?

@a-b-r-o-w-n
Copy link
Contributor Author

@sangwoohaan do you have guidance here? It's possible for users to add values that are objects with any types in them and arrays with any types in them.

ex:

{
  "user": { "address": { "city": "Bellevue" } },
  "places": [{ "name": "Office" }, { "name": "Home" }]
}

@sangwoohaan
Copy link
Contributor

If values are objects or arrays they should display the actual values, but truncate if it doesn't fit in one line.
Group 720
Something like this

yeze322 added a commit to yeze322/BotFramework-Composer that referenced this issue Mar 23, 2020
@yeze322
fix🐞(uischema): show object value
f0c67dc 
In 'Microsoft.SetProperties', the 'value' field of an assignment could be either object or string. Stringify the value if it's an object.
microsoft#2309
@yeze322 yeze322 mentioned this issue Mar 23, 2020
Merged
@yeze322
Copy link
Contributor

yeze322 commented Mar 23, 2020

addressed in #2335

a-b-r-o-w-n added a commit that referenced this issue Mar 23, 2020
@yeze322 @a-b-r-o-w-n
fix: display object types correctly in SetProperties (#2335)
3ca3cf9 
In 'Microsoft.SetProperties', the 'value' field of an assignment could be either object or string. Stringify the value if it's an object.
#2309

Co-authored-by: Andy Brown <asbrown002@gmail.com>
@hibrenda hibrenda added the R9 Release 9 - May 15th, 2020 label Mar 26, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this issue Jun 15, 2021
@yeze322 @a-b-r-o-w-n
fix: display object types correctly in SetProperties (microsoft#2335)
554d5a4 
In 'Microsoft.SetProperties', the 'value' field of an assignment could be either object or string. Stringify the value if it's an object.
microsoft#2309

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanlong9278 alanlong9278

@yeze322 yeze322

Labels
R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@a-b-r-o-w-n @alanlong9278 @yeze322 @hibrenda @sangwoohaan