Skill Dialog Samples #2245
Merged
Skill Dialog Samples #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated some strings. Removed TangentDialog sample. Added AllowedCallersClaimsValidator to the skill. Updated nuget packages to use 4.8 rc2
…oft/botbuilder-samples into skills/SkillDialogSamples
Removed UserSecretsId from simple sample (that may cause confusion when cloning csproj). Updated ActivityRouterDialog logic to handle messages that understands from LUIS. Added readmes Removed OAuth tests.
…oft/BotBuilder-Samples into skills/SkillDialogSamples
gabog
requested review from
axelsrz,
stevengum,
JonathanFingold and
mdrichardson
Deleted Experimental version the DialogToDialog sample. DialogRootBot: * Renamed AllowedCallersClaimsValidator to AllowedSkillsClaimsValidator * Added DeploymentTemplates DialogSkillBot: * Removed extra SkillController (not used) * Added DeploymentTemplates * Updated manifest to use 000 GUID.
Updated formatting
…oft/botbuilder-samples into skills/SkillDialogSamples
- Small grammar changes and markdown changes.
- added READMEs - allowedCallers checks for '*' - added .env files - added manifests
…oft/botbuilder-samples into skills/SkillDialogSamples
…oft/BotBuilder-Samples into skills/SkillDialogSamples
…osoft/BotBuilder-Samples into skills/SkillDialogSamples
Removed conversationState from SkillAdapterWithErrorHandler (it is not being used in sample 80)
…uilder-Samples into skills/SkillDialogSamples
…ry methods (and stop using deprecated ones).
- updated packages
mdrichardson
approved these changes
Mar 24, 2020
samples/javascript_nodejs/80.skills-simple-bot-to-bot/echo-skill-bot/index.js
Show resolved
Hide resolved
added 3 commits
March 24, 2020 16:25
mdrichardson
force-pushed
the
skills/SkillDialogSamples
branch
from
87ae32f to
5153de0
Compare
…oft/BotBuilder-Samples into skills/SkillDialogSamples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2251
Fixes #2106
Fixes #2194