Features/484133 drag and drop attach multiple files (email attachment part) #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gggdttt
assigned gggdttt, haoranpb and JesperSchulz and unassigned JesperSchulz, haoranpb and gggdttt
haoranpb
requested changes
Mar 27, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Show resolved
Hide resolved
pri-kise
reviewed
Mar 28, 2024
src/System Application/App/Email/src/Message/EmailAttachments.Page.al
Outdated
Show resolved
Hide resolved
gggdttt
changed the title
gggdttt
changed the title
gggdttt
commented
Apr 2, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Show resolved
Hide resolved
haoranpb
previously approved these changes
Apr 3, 2024
AndreasMoth
reviewed
Apr 5, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Show resolved
Hide resolved
AndreasMoth
reviewed
Apr 5, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Apr 5, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Apr 5, 2024
src/System Application/App/Email/src/Email/Outbox/EmailEditor.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Apr 5, 2024
haoranpb
approved these changes
Apr 8, 2024
added 11 commits
April 10, 2024 14:32
This reverts commit 6a50c06.
gggdttt
force-pushed
the
features/484133-Drag-and-Drop-Attach-multiple-files
branch
from
5ec79ed to
c33203c
Compare
darjoo
approved these changes
Apr 10, 2024
JesperSchulz
approved these changes
Apr 10, 2024
gggdttt
added a commit
that referenced
this pull request
Apr 15, 2024
… part) (#842) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Part of the slice work - support drag and drop multiple file in Email attachment #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> * Also refactor some code * support drag and drop multiple file in Email attachment * No test for now because cannot init `fileUpload` in AL now, need to wait for the testability from Develop Tool Team and then add tests * [AB#484133](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/484133/) --------- Co-authored-by: Wenjie Fan <wenjiefan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the slice work - support drag and drop multiple file in Email attachment
Work Item(s)
fileUploadin AL now, need to wait for the testability from Develop Tool Team and then add tests