Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to backporting tool #679

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Improvements to backporting tool #679

merged 5 commits into from
Mar 7, 2024

Conversation

aholstrup1
Copy link
Contributor

@aholstrup1 aholstrup1 commented Mar 4, 2024 •
edited by github-actions bot
Loading

Summary

  • If gh cli isn't installed, link to a winget command rather than a URL
  • Improved error message if branch doesn't exist
  • Ability to run New-BCAppsBackport from outside your local BCApps repository folder

Work Item(s)

Fixes AB#498430

@aholstrup1 aholstrup1 requested a review from a team as a code owner March 4, 2024 08:58
@github-actions github-actions bot added the Build: scripts & configs Build scripts and configuration files label Mar 4, 2024
@github-actions github-actions bot added this to the Version 25.0 milestone Mar 4, 2024
mazhelez
mazhelez previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, but overall looks great.

mazhelez
mazhelez previously approved these changes Mar 6, 2024
View reviewed changes
darjoo
darjoo previously approved these changes Mar 6, 2024
View reviewed changes
@aholstrup1 aholstrup1 dismissed stale reviews from darjoo and mazhelez via d2eaae2 March 7, 2024 07:23
@aholstrup1 aholstrup1 requested review from mazhelez and darjoo March 7, 2024 07:26
@aholstrup1 aholstrup1 enabled auto-merge (squash) March 7, 2024 12:59
@aholstrup1 aholstrup1 merged commit 9c36715 into main Mar 7, 2024
30 checks passed
@aholstrup1 aholstrup1 deleted the private/aholstrup/backportimprovements branch March 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darjoo darjoo darjoo approved these changes

@mazhelez mazhelez mazhelez approved these changes

Assignees
No one assigned
Labels
Build: scripts & configs Build scripts and configuration files
Projects
None yet
Milestone
Version 25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aholstrup1 @darjoo @mazhelez