Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1409 do not modify record if its empty #1419

Closed
wants to merge 3 commits into from

Conversation

SlavaGeorgiev
Copy link

Summary

Fixes the bug, when a AFS directory is empty or the AFSDirectoryContent Table is empty, that no modify happens

Work Item(s) >

Fixes #1409

@SlavaGeorgiev SlavaGeorgiev requested a review from a team as a code owner June 27, 2024 08:58
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Jun 27, 2024
Copy link

Issue #1409 is not valid. Please make sure you link an issue that exists, is open and is approved.

@SlavaGeorgiev
Copy link
Author

@microsoft-github-policy-service agree

@SlavaGeorgiev
Copy link
Author

@JesperSchulz requesting review

@NKarolak
Copy link
Contributor

Issue #1409 is not valid. Please make sure you link an issue that exists, is open and is approved.

@SlavaGeorgiev You cannot request a review for this PR until issue #1409 got the approved label by Microsoft.

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jul 1, 2024
@pri-kise
Copy link
Contributor

pri-kise commented Jul 3, 2024

@SlavaGeorgiev can you maybe add a new test in
https://github.com/microsoft/BCApps/blob/main/src/System%20Application/Test/Azure%20File%20Services%20API/src/AFSFileClientTest.Codeunit.al
for this specific case?

@JesperSchulz
Copy link
Contributor

Given this PR addresses the same issue as #1408, I will close this one as a duplicate.
Going forward, please coordinate with the creator of an issue who is to deliver a fix to avoid wasting your time 😊
But thanks for taking a stab at this 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: setting nextmarker in AFSFileClientImpl.codeunit results in an error if nothing is found
4 participants