GetNextNo should error when line is closed, not take a number from an earlier line #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darjoo
approved these changes
Jun 26, 2024
mazhelez
approved these changes
Jun 27, 2024
gggdttt
pushed a commit
that referenced
this pull request
Jun 27, 2024
… earlier line (#1406) <!-- Thank you for your contribution to BCApps! For newcomers, please ensure you've read our [Pull Request Guidelines](https://github.com/microsoft/BCApps/Contributing.md). --> ### Summary This PR addresses a bug in the `GetNoSeriesLine` function where it failed to properly handle closed lines. Previously, if a line for a specific month was closed, the system would incorrectly issue a number from a prior month instead of signaling an error. This fix ensures that an error is thrown as expected in such scenarios, aligning with the intended behavior when dealing with closed series lines. ### Work Item - Fixes [AB#538011](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/538011)
gggdttt
pushed a commit
that referenced
this pull request
Jun 27, 2024
… earlier line (#1406) <!-- Thank you for your contribution to BCApps! For newcomers, please ensure you've read our [Pull Request Guidelines](https://github.com/microsoft/BCApps/Contributing.md). --> ### Summary This PR addresses a bug in the `GetNoSeriesLine` function where it failed to properly handle closed lines. Previously, if a line for a specific month was closed, the system would incorrectly issue a number from a prior month instead of signaling an error. This fix ensures that an error is thrown as expected in such scenarios, aligning with the intended behavior when dealing with closed series lines. ### Work Item - Fixes [AB#538011](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/538011)
gggdttt
pushed a commit
that referenced
this pull request
Jun 27, 2024
… earlier line (#1406) <!-- Thank you for your contribution to BCApps! For newcomers, please ensure you've read our [Pull Request Guidelines](https://github.com/microsoft/BCApps/Contributing.md). --> ### Summary This PR addresses a bug in the `GetNoSeriesLine` function where it failed to properly handle closed lines. Previously, if a line for a specific month was closed, the system would incorrectly issue a number from a prior month instead of signaling an error. This fix ensures that an error is thrown as expected in such scenarios, aligning with the intended behavior when dealing with closed series lines. ### Work Item - Fixes [AB#538011](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/538011)
gggdttt
pushed a commit
that referenced
this pull request
Jun 27, 2024
… earlier line (#1406) <!-- Thank you for your contribution to BCApps! For newcomers, please ensure you've read our [Pull Request Guidelines](https://github.com/microsoft/BCApps/Contributing.md). --> ### Summary This PR addresses a bug in the `GetNoSeriesLine` function where it failed to properly handle closed lines. Previously, if a line for a specific month was closed, the system would incorrectly issue a number from a prior month instead of signaling an error. This fix ensures that an error is thrown as expected in such scenarios, aligning with the intended behavior when dealing with closed series lines. ### Work Item - Fixes [AB#538011](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/538011)
gggdttt
added a commit
that referenced
this pull request
Jun 28, 2024
…a number from an earlier line (#1425) This pull request backports #1406 to releases/24.x Fixes [AB#539651](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/539651) Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
gggdttt
added a commit
that referenced
this pull request
Jul 1, 2024
…a number from an earlier line (#1426) This pull request backports #1406 to releases/24.0 Fixes [AB#539648](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/539648) Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
gggdttt
added a commit
that referenced
this pull request
Jul 1, 2024
…a number from an earlier line (#1428) This pull request backports #1406 to releases/24.2 Fixes [AB#539650](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/539650) Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
gggdttt
added a commit
that referenced
this pull request
Jul 1, 2024
…a number from an earlier line (#1427) This pull request backports #1406 to releases/24.1 Fixes [AB#539649](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/539649) Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug in the
GetNoSeriesLinefunction where it failed to properly handle closed lines. Previously, if a line for a specific month was closed, the system would incorrectly issue a number from a prior month instead of signaling an error. This fix ensures that an error is thrown as expected in such scenarios, aligning with the intended behavior when dealing with closed series lines.Work Item