[24.x] Duplicate resource file for AL error OnPrem #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> If compiling the System Application OnPrem using Get-NavAppRuntimePackage , this will fail with missing resource file error. This is because of the compiler failing to resolve relative paths properly. Mitigation for now has been to duplicate all resource files. This was not duplicated, hence duplicating while waiting for a proper compiler fix. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#534969](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/534969)
grobyns
approved these changes
Jun 24, 2024
stkillen
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If compiling the System Application OnPrem using
Get-NavAppRuntimePackage , this will fail with missing resource file error. This is because of the compiler failing to resolve relative paths properly. Mitigation for now has been to duplicate all resource files. This was not duplicated, hence duplicating while waiting for a proper compiler fix.
Work Item(s)
Fixes
AB#534969
Summary
Work Item(s)
Fixes AB#539033