-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC Idea]: Add PUT method to Graph API Module #748
Comments
I'm really looking forward to this PR. |
Based on @duichwer's comment, this seems to be something we want 😉 Approved. |
@devgar I don't know any endpoints of the Microsoft Graph API that support HEAD or OPTIONS request. |
Excellent, In what release version will it be available in? |
Unfortunately the change came in too late to be part of the April release (24.0). By default your changes will hence release with the next major (25.0 in October), but if you need them sooner, we can backport your changes to release with version 24.1 in May. |
It would feel great if it fits in 24.1 or 24.2 |
You got it! I'll make sure it releases with 24.1 🙂 |
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This implement's HTTP Put Method in Graph API Wrapper. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #748 Fixes [AB#507963](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/507963)
Reopening to backport to 24.x. |
Backport of #773 Fixes #748 Fixes [AB#522599](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/522599) Co-authored-by: Edgar Albalate Ibañez <dev.gardo@gmail.com>
BC Idea Link
https://experience.dynamics.com/ideas/idea/?ideaid=160fc653-dde1-ee11-a73e-002248504629
Description
Currently Graph API module's "Graph Client" Codeunit has Get, Post, Patch and Delete Methods but lacks a PUT method which is also required for some microsoft graph requests.
It also lacks OPTIONS and HEAD methods which are common HTTP Methods but I don't realy know if they are common on Microsoft Graph.
I propose to include the PUT method, I have an initial implementation which could be included through pull request on GitHub.
I will provide the implementation for this BC Idea
The text was updated successfully, but these errors were encountered: