Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing docker registry username and pass from API config #609

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Removing docker registry username and pass from API config #609

merged 1 commit into from
Aug 12, 2021

Conversation

deniscep
Copy link
Contributor

Removing docker registry username and pass from API config

What is being addressed

Docker credentials are pushed to API, but have already been replaced by MSI downstream. Removing the credentials.

How is this addressed

  • Removed the credentials from TF so they are not pushed to API config

Closing #575

@deniscep deniscep self-assigned this Aug 12, 2021
@deniscep deniscep linked an issue Aug 12, 2021 that may be closed by this pull request
[Task] Verify docker credentials are not passed/stored #575
Closed
@github-actions
Copy link

github-actions bot commented Aug 12, 2021 •
edited
Loading

Unit Test Results

1 files  ±0  1 suites  ±0   3m 15s ⏱️ ±0s
9 tests ±0  9 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1c340bd. ± Comparison against base commit 1c340bd.

♻️ This comment has been updated with latest results.

TessFerrandez
TessFerrandez approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@TessFerrandez TessFerrandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deniscep deniscep merged commit 1c340bd into develop Aug 12, 2021
@deniscep deniscep deleted the deniscep/575-docker-cred-cleanup branch August 12, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessFerrandez TessFerrandez TessFerrandez approved these changes

@marrobi marrobi Awaiting requested review from marrobi

Assignees

@deniscep deniscep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Verify docker credentials are not passed/stored
2 participants
@deniscep @TessFerrandez