Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMK encryption support for Azure Container Registry (ACR) and Service Bus #4178

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Dec 10, 2024

Part of #4142

What is being addressed

  • Added CMK for ACR and SB
  • Renamed the encryption key to include the TRE ID

Copy link

github-actions bot commented Dec 10, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f4d2b45.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron changed the title 4142 add cmk for acr and sb Add CMK encryption support for Azure Container Registry (ACR) and Service Bus Dec 10, 2024
@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12261875857 (with refid 6e8636eb)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12263143495 (with refid 6e8636eb)

(in response to this comment from @yuvalyaron)

Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test-force-approve

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f4d2b45)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 6146484 into microsoft:main Dec 11, 2024
12 checks passed
@yuvalyaron yuvalyaron deleted the 4142-add-cmk-for-acr-and-sb branch December 11, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants