Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unrestricted & airlock review workspace base version #4087

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Sep 5, 2024

This is a follow up to #3970 PR which amended the base workspace for Azure SQL support.

Workspaces derived from base (i.e. unrestricted and airlock-import-review) both pull in the base workspace code from GitHub again using a git ref.

This PR amends the base version to 0.19.0 that the following workspace templates are built off:

  • unrestricted
  • airlock import review

This allows these workspaces to use the Azure SQL component.

Copy link

github-actions bot commented Sep 5, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 72af49b.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-p-allen tim-p-allen enabled auto-merge (squash) September 17, 2024 09:08
@tim-p-allen
Copy link
Collaborator

@jonnyry can you update the branch? then we can merge it in

@jonnyry
Copy link
Collaborator Author

jonnyry commented Sep 18, 2024

@jonnyry can you update the branch? then we can merge it in

Done

@tim-p-allen
Copy link
Collaborator

/test

Copy link

🤖 pr-bot 🤖

⚠️ When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator

/test 72af49b

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/10922547237 (with refid c7cd5dea)

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator

/test-destroy-env

Copy link

Destroying PR test environment (RG: rg-trec7cd5dea)... (run: https://github.com/microsoft/AzureTRE/actions/runs/10937723742)

Copy link

PR test environment destroy complete (RG: rg-trec7cd5dea)

@tim-p-allen
Copy link
Collaborator

/test 72af49b

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/10938181987 (with refid c7cd5dea)

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator

/test-destroy-env

Copy link

Destroying PR test environment (RG: rg-trec7cd5dea)... (run: https://github.com/microsoft/AzureTRE/actions/runs/10939609690)

Copy link

PR test environment destroy complete (RG: rg-trec7cd5dea)

@tim-p-allen
Copy link
Collaborator

/test

Copy link

🤖 pr-bot 🤖

⚠️ When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator

/test 72af49b

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/10940340105 (with refid c7cd5dea)

(in response to this comment from @tim-allen-ck)

@tim-p-allen tim-p-allen merged commit 7dd1915 into microsoft:main Sep 19, 2024
12 checks passed
@jonnyry jonnyry deleted the jr/61-update-workspace-base-version branch September 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants