Skip to content

make check-params uses remote bundle #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 1, 2023

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Since porter 'autobuild' interferes with some of our template check procedures we need to temporarily adjust how they are performed. parent issue: #3146

How is this addressed

  • Remove bundle-check-params from any local development path that is using a bundle from the local machine.
  • Create a new target bundle-check-params-remote that will use a bundle from a remote registry which could be used after publish (and before registration)

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 25254f7.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4043921048 (with refid 8cebe8a1)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4052843484 (with refid 8cebe8a1)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying branch test environment (RG: rg-tref2254d4c)... (run: https://github.com/microsoft/AzureTRE/actions/runs/4055171471)

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre8cebe8a1)... (run: https://github.com/microsoft/AzureTRE/actions/runs/4055171471)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tref2254d4c)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre8cebe8a1)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4061359813 (with refid 8cebe8a1)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 253e07b into main Feb 1, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3146-bundle-check-params-remote branch February 1, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants