Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically validate all resources have tre_id tag via TFLint #2774

Merged
merged 7 commits into from
Oct 24, 2022
Merged

Automatically validate all resources have tre_id tag via TFLint #2774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20d5178
adding missing costs resource tags tflint rule
guybartal Oct 23, 2022
f236b7e
update changelog
guybartal Oct 23, 2022
d1fc00e
test missing resource tags
guybartal Oct 23, 2022
d2bf581
undo remove tags for test
guybartal Oct 23, 2022
8e5af4d
Merge branch 'main' into guybartal/add-missing-costs-tags-tflint-rule
guybartal Oct 24, 2022
9ee3c64
Update CHANGELOG.md
guybartal Oct 24, 2022
bcbc8e8
move item in changelog to 0.7.0
guybartal Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/linters/.tflint.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,8 @@ rule "terraform_naming_convention" {
rule "terraform_standard_module_structure" {
enabled = true
}

rule "azurerm_resource_missing_tags" {
enabled = true
tags = ["tre_id"]
}
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

FEATURES:
* Display workspace and shared services total costs for admin role in UI [#2738](https://github.com/microsoft/AzureTRE/pull/2772)
* Automatically validate all resources have tre_id tag via TFLint [#2774](https://github.com/microsoft/AzureTRE/pull/2774)

ENHANCEMENTS:

Expand All @@ -21,6 +22,7 @@ FEATURES:
* New Create Review VM functionality for Airlock Reviews ([#2738](https://github.com/microsoft/AzureTRE/pull/2759) & [#2737](https://github.com/microsoft/AzureTRE/pull/2740))



ENHANCEMENTS:
* Add cran support to nexus, open port 80 for the workspace nsg and update the firewall config to allow let's encrypt CRLs ([#2694](https://github.com/microsoft/AzureTRE/pull/2694))
* Upgrade Github Actions versions ([#2731](https://github.com/microsoft/AzureTRE/pull/2744))
Expand Down