-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import reviewer VM #2636
Import reviewer VM #2636
Conversation
...ce_services/guacamole/user_resources/guacamole-azure-importreview-vm/delete_vm_extensions.sh
Outdated
Show resolved
Hide resolved
...orkspace_services/guacamole/user_resources/guacamole-azure-importreview-vm/reset_password.sh
Outdated
Show resolved
Hide resolved
...space_services/guacamole/user_resources/guacamole-azure-importreview-vm/template_schema.json
Show resolved
Hide resolved
/test |
🤖 pr-bot 🤖
(in response to this comment from @tanya-borisova) |
/test 618f5fe |
🤖 pr-bot 🤖
(in response to this comment from @tanya-borisova) |
/test eb4606d |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3113305495 (with refid (in response to this comment from @tanya-borisova) |
…://github.com/JaimieWi/AzureTRE into JaimieWi/2601-reviewer_user_resource_template
/test a8b6ab9 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3127024494 (with refid (in response to this comment from @tanya-borisova) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it's almost there, couple of comments re shared storage, if it's always going to be false, lets set it that way.
.../workspace_services/guacamole/user_resources/guacamole-azure-importreview-vm/parameters.json
Outdated
Show resolved
Hide resolved
...ates/workspace_services/guacamole/user_resources/guacamole-azure-importreview-vm/porter.yaml
Outdated
Show resolved
Hide resolved
...ates/workspace_services/guacamole/user_resources/guacamole-azure-importreview-vm/porter.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @tanya-borisova can you create an issue and assign to yourself to update the .diff when it can be? Thanks.
…://github.com/JaimieWi/AzureTRE into JaimieWi/2601-reviewer_user_resource_template
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 9f76504) (in response to this comment from @tanya-borisova) |
(Force-approve because this doesn't touch TRE core, just adding a new template) |
Resolves #2601
What is being addressed
A new user resource template (Guacamole VM) is required to review import data requests.
How is this addressed
make bundle-build bundle-publish bundle-register
and creating a VM from the template.