-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict resource templates to specific roles #2623
Restrict resource templates to specific roles #2623
Conversation
…e dont have access to
…rce-templates-to-specific-roles
…es-to-specific-roles' of github.com:microsoft/AzureTRE into tborisova/2600-add-ability-to-restrict-resource-templates-to-specific-roles
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3093679398 (with refid (in response to this comment from @tanya-borisova) |
/test-destroy-env |
…rce-templates-to-specific-roles
Destroying branch test environment (RG: rg-tre1b5504b3)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3095882735) |
Branch test environment destroy complete (RG: rg-tre1b5504b3) |
Destroying PR test environment (RG: rg-tredd6692a5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3095882735) |
…es-to-specific-roles' of github.com:microsoft/AzureTRE into tborisova/2600-add-ability-to-restrict-resource-templates-to-specific-roles
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3095968260 (with refid (in response to this comment from @tanya-borisova) |
PR test environment destroy complete (RG: rg-tredd6692a5) |
/test-destroy-env |
Branch test environment destroy complete (RG: rg-tre1b5504b3) |
PR test environment destroy complete (RG: rg-tredd6692a5) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3098525208 (with refid (in response to this comment from @tanya-borisova) |
/test-destroy-env |
Destroying branch test environment (RG: rg-tre1b5504b3)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3100304315) |
Branch test environment destroy complete (RG: rg-tre1b5504b3) |
Destroying PR test environment (RG: rg-tredd6692a5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3100304315) |
PR test environment destroy complete (RG: rg-tredd6692a5) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3100722085 (with refid (in response to this comment from @tanya-borisova) |
Moved it back to draft temporarily as @damoodamoo pointed out that there's a problem: the GET methods for templates are on the root router so we won't get workspace-level roles there. |
…emplates on workspace level
…es-to-specific-roles' of github.com:microsoft/AzureTRE into tborisova/2600-add-ability-to-restrict-resource-templates-to-specific-roles
…rce-templates-to-specific-roles
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3106126999 (with refid (in response to this comment from @tanya-borisova) |
…rce-templates-to-specific-roles
…es-to-specific-roles' of github.com:microsoft/AzureTRE into tborisova/2600-add-ability-to-restrict-resource-templates-to-specific-roles
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3106591276 (with refid (in response to this comment from @tanya-borisova) |
Resolves #2600
What is being addressed
Add ability to restrict certain user resource templates to be used by certain roles.
This is primarily needed for Airlock Reviews, where the Reviewer should not be able to use user resource templates intended for Researchers. However, it might be used in the future for other resource templates.
How is this addressed
Note that the template.authorizedRoles are only checked on creation of the resource. This is intentional although may appear somewhat inconsistent