Switches signature checking to p/invoke #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on merging this until we get an opinion on including the code derived from StackOverflow, which I think is CC-BY-SA, which we might not be compatible with. |
|
Got it. I could probably re-write it based on the example from p-invoke.net which has a non-encumbered license. I just checked and code from post 2016 is MIT but before that is CC-BY-SA and unfortunately this was posted in 2011. |
added 2 commits
April 6, 2019 14:51
|
@scovetta I went ahead and rewrote it based only on the code from pinvoke.net. I think we are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30.
This also dramatically improves collection time on Windows. I'm seeing 5 minutes on one of my machines now.