Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension methods to retrieve specific operation details #2566

Merged
merged 2 commits into from
May 13, 2022
Merged

Add extension methods to retrieve specific operation details #2566

merged 2 commits into from
May 13, 2022

Conversation

OskarKlintrot
Copy link
Contributor

Fix Issue #1350 .

Changes

Added the methods suggested in #1350.

Checklist

  • I ran Unit Tests locally (that I added, a lot is failing locally in main on my machine).
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@OskarKlintrot
Copy link
Contributor Author

OskarKlintrot commented Mar 30, 2022

Does it still make sense to have OperationDetailConstants public? I noticed it haven't shipped yet. I would assume you would prefer to have a small public surface?

I noticed the request detail can be HttpWebRequest and the response detail can be HttpWebResponse so I guess they can be left public.

Copy link
Member

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants