-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert projects to use FrameworkReference #2355
Conversation
<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="1.1.8" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. By default all ASP.NET Core 2.1 app had IHostingEnvironment
reference in startup.cs
. As we are retiring .NET Core 2.1 we need to move from IHostingEnvironment
to IWebHostEnvironment
. This change is not simple, it requires modification to DefaultApplicationInsightsServiceConfigureOptions.cs
. This is out of the scope for this PR.
Fix Issue #2251
This affects test projects.
Our SDKs target NetStandard2.0, but our Test projects target individual frameworks.
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build