-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype] Support ActivityLinks #2185
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
cc @lmolkova |
Hey, @TimothyMothra @cijothomas! We made the change on Azure SDK side to add an experimental ActivitySource support. How can I help you make a decision on this PR? |
/AzurePipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
...encyCollector/DependencyCollector/Implementation/AzureSdk/AzureSdkDiagnosticsEventHandler.cs
Outdated
Show resolved
Hide resolved
...encyCollector/DependencyCollector/Implementation/AzureSdk/AzureSdkDiagnosticsEventHandler.cs
Outdated
Show resolved
Hide resolved
Test failures seem unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@rajkumar-rangaraj Need your input before merging, as you were trying to downgrade minimum DS version (if that happens, then this PR will fail).
@pakrym Could you update changelog (if possible, mention the version of Azure SDKs which support ActivitySource)
/AzurePipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @rajkumar-rangaraj Need your input before merging, as you were trying to downgrade minimum DS version (if that happens, then this PR will fail).
@pakrym Could you update changelog (if possible, mention the version of Azure SDKs which support ActivitySource)
I ran the pipeline with Redfield
set, build fails. Taking the changes in the current way makes if difficult for to use #REDFIELD
as the function parameters are changing. We might need to have the functionality to skip Redfield. This requires some time and I will take a look into it.
@rajkumar-rangaraj any news on this? The .NET 5 activity link support has shipped in Azure SDKs |
This PR is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. |
Currently, Azure SDKs produce a special kind of Activities that carries links in a
property.
Migration to ActivitySource based activities would result in the same information being carried in the
https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.activity.links?view=net-5.0
This PR add support for collecting both ways of representing links.