Updated version of System.Diagnostics.DiagnosticSource to 4.6.0-preview7 #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c76aaa7.
lmolkova
reviewed
Jul 30, 2019
| @@ -31,7 +31,7 @@ | |||
| <PackageReference Include="MSTest.TestFramework" Version="1.4.0" /> | |||
| <PackageReference Include="CompareNETObjects" Version="4.59.0" /> | |||
| <PackageReference Include="Newtonsoft.Json" Version="10.0.3" /> | |||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="4.5.0" /> | |||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="4.6.0-preview7.19362.9" /> | |||
There was a problem hiding this comment.
all these projects except Ms.AppInsights.csproj don't need a direct reference to DiagnosticSource (they'll get it with Ms.AppInsights dependency implicitly). Maybe we should remove the reference instead of updating it?
lmolkova
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of System.Diagnostics.DiagnosticSource to 4.6.0-preview7.19362.9. This will be updated to 4.6.0 stable when it releases, and before 2.11.0 stable release.
This is a pre-req to leveraging new W3C capabilities in 4.6.0.
This also removed sdk from being cls compliant as the dependency (System.Diagnostics.DiagnosticSource) is no longer compliant to cls.