SDKVersion to hint NETCORE, other minor changes #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e source of code path, as implementations are slightly different for NetCore
…soft/ApplicationInsights-dotnet into cithomas/sdkversionnetcore
Dmitry-Matveev
approved these changes
Apr 26, 2019
| @@ -22,7 +22,11 @@ | |||
| /// </summary> | |||
| public sealed class TelemetryClient | |||
| { | |||
| #if NETSTANDARD1_3 || NETSTANDARD2_0 | |||
| private const string VersionPrefix = "dotnetc:"; | |||
There was a problem hiding this comment.
Some BI reports / business telemetry may need to get corrected. Can you please email PM team about this change after it's in?
There was a problem hiding this comment.
Yes. https://github.com/Microsoft/ApplicationInsights-home Will update the SDKVersion here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDKVersion updated to hint the target is NETCORE.
Linux builds netstandard2.0 as well
For significant contributions please make sure you have completed the following items:
Design discussion issue #
Changes in public surface reviewed
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/.github/CONTRIBUTING.md) instructions to build and test locally.