Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching exception when failing to read config in partial trust #1119

Merged
merged 4 commits into from
Apr 26, 2019

Conversation

stimms
Copy link
Contributor

@stimms stimms commented Apr 24, 2019

Fix Issue #416 .

Expand the area under try catch to allow for client initialization in partial trust scenarios, specifically as part of a Dynamics 365 plugin.

  • [x ] I ran Unit Tests locally.

@msftclas
Copy link

msftclas commented Apr 24, 2019

CLA assistant check
All CLA requirements met.

@stimms
Copy link
Contributor Author

stimms commented Apr 24, 2019

I'd love some insight as to why the build failed on this trivial change but the devops builds aren't publicly accessible.

@cijothomas cijothomas closed this Apr 24, 2019
@cijothomas cijothomas reopened this Apr 24, 2019
Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azurepipelines infra is down. nothing to do with this PR. will merge after we get infra back.

@cijothomas cijothomas closed this Apr 25, 2019
@cijothomas cijothomas reopened this Apr 25, 2019
@cijothomas
Copy link
Contributor

@stimms The build is failing with stylecop checks. Can you build locally in Release, and you will be able to see the same errors.

@cijothomas
Copy link
Contributor

There is this test failure, about the new Warning trace.

Test method Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing.CoreEventSourceTest.MethodsAreImplementedConsistentlyWithTheirAttributes threw exception:
System.Exception: ApplicationInsightsConfigNotAccessibleWarning is implemented incorrectly: EventId. expected: '45', actual: '0' ---> System.Exception: EventId. expected: '45', actual: '0'

Stack trace
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.AssertEqual[T](T expected, T actual, String message) in \Test\TestFramework\Shared\EventSourceTest.cs:line 115
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.VerifyEventId(MethodInfo eventMethod, EventWrittenEventArgs actualEvent) in \Test\TestFramework\Shared\EventSourceTest.cs:line 76
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.VerifyMethodImplementation(EventSource eventSource, MethodInfo eventMethod) in \Test\TestFramework\Shared\EventSourceTest.cs:line 34
--- End of inner exception stack trace ---
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.VerifyMethodImplementation(EventSource eventSource, MethodInfo eventMethod) in \Test\TestFramework\Shared\EventSourceTest.cs:line 41
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.MethodsAreImplementedConsistentlyWithTheirAttributes(EventSource eventSource) in \Test\TestFramework\Shared\EventSourceTest.cs:line 18
at Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing.CoreEventSourceTest.MethodsAreImplementedConsistentlyWithTheirAttributes() in \Test\Microsoft.ApplicationInsights.Test\Shared\Extensibility\Implementation\Tracing\CoreEventSourceTest.cs:line 14

@cijothomas
Copy link
Contributor

Failed MethodsAreImplementedConsistentlyWithTheirAttributes
Error Message:
Test method Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing.CoreEventSourceTest.MethodsAreImplementedConsistentlyWithTheirAttributes threw exception:
System.Exception: ApplicationInsightsConfigNotAccessibleWarning is implemented incorrectly: EventId. expected: '45', actual: '0' ---> System.Exception: EventId. expected: '45', actual: '0'
Stack Trace:
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.AssertEqual[T](T expected, T actual, String message) in /mnt/a/1/s/Test/TestFramework/Shared/EventSourceTest.cs:line 115
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.VerifyMethodImplementation(EventSource eventSource, MethodInfo eventMethod) in /mnt/a/1/s/Test/TestFramework/Shared/EventSourceTest.cs:line 35
--- End of inner exception stack trace ---
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.VerifyMethodImplementation(EventSource eventSource, MethodInfo eventMethod) in /mnt/a/1/s/Test/TestFramework/Shared/EventSourceTest.cs:line 41
at Microsoft.ApplicationInsights.TestFramework.EventSourceTest.MethodsAreImplementedConsistentlyWithTheirAttributes(EventSource eventSource) in /mnt/a/1/s/Test/TestFramework/Shared/EventSourceTest.cs:line 16

@cijothomas
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

For the Azure DevOps organization bhyada, no matching pipelines using the Azure Pipelines app were found for this pull request.

@cijothomas
Copy link
Contributor

/azp help

@azure-pipelines
Copy link

Supported commands
     help:
          Get descriptions, examples and documentation about supported commands
          Example: help "command_name"
     run:
          Run all pipelines or a specific pipeline for this repository using a comment. Use
          this command by itself to trigger all related pipelines, or specify a pipeline
          to run.
          Example: "run" or "run pipeline_name"

See additional documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants