Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: Remove Proxy class: SamplingPercentageEstimatorSettings #776

Closed
TimothyMothra opened this issue Apr 16, 2018 · 1 comment
Closed

Release: Remove Proxy class: SamplingPercentageEstimatorSettings #776

TimothyMothra opened this issue Apr 16, 2018 · 1 comment
Labels
breaking-change Requires breaking change, only fits into a major version bump stale

Comments

@TimothyMothra
Copy link
Member

See #727 and #775

SamplingPercentageEstimatorSettings had its namespace changed during a project cleanup.
A proxy class was added at the former namespace to support backward compatibility.

  • Delete proxy class
  • Make base class sealed
@TimothyMothra TimothyMothra added this to the 3.0 milestone Apr 16, 2018
TimothyMothra pushed a commit that referenced this issue Oct 25, 2019
@cijothomas
Merge pull request #776 from Microsoft/cithomas/251
6e7c121 
Update 2.5.1
@TimothyMothra TimothyMothra changed the title 3.0 Release: Remove Proxy class: SamplingPercentageEstimatorSettings [3.0] Release: Remove Proxy class: SamplingPercentageEstimatorSettings Jul 28, 2020
@reyang reyang changed the title [3.0] Release: Remove Proxy class: SamplingPercentageEstimatorSettings Release: Remove Proxy class: SamplingPercentageEstimatorSettings Mar 9, 2021
@reyang reyang added the breaking-change Requires breaking change, only fits into a major version bump label Mar 9, 2021
@reyang reyang removed this from the 3.0 milestone Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

This issue is stale because it has been open 300 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Requires breaking change, only fits into a major version bump stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyang @TimothyMothra