This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
SDK Connection Strings (Net Core support) #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Sep 26, 2019
...rosoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs
Show resolved
Hide resolved
cijothomas
reviewed
Sep 26, 2019
...rosoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs
Show resolved
Hide resolved
cijothomas
reviewed
Sep 26, 2019
src/Shared/Implementation/TelemetryConfigurationOptionsSetup.cs
Outdated
Show resolved
Hide resolved
TimothyMothra
changed the title
…t/ApplicationInsights-aspnetcore into tilee/connectionStrings
cijothomas
reviewed
Oct 10, 2019
cijothomas
reviewed
Oct 10, 2019
cijothomas
approved these changes
Oct 10, 2019
|
I didn't see your comments until after I clicked merge. I'm reviewing now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/ApplicationInsights-dotnet#1221
TODO
Changes