This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Do not set sampledOut flag if activity is recorded and parentId fixes #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitry-Matveev
approved these changes
Sep 8, 2019
cijothomas
reviewed
Sep 9, 2019
| config.SetLastObservedSamplingPercentage(SamplingTelemetryItemTypes.Request, 0); | ||
|
|
||
| HttpContext context = CreateContext(HttpRequestScheme, HttpRequestHost, "/Test", method: "POST"); | ||
| var traceParent = "00-4e3083444c10254ba40513c7316332eb-e2a5f830c0ee2c46-01"; |
There was a problem hiding this comment.
perhaps a test with -00 for Recorded flag?
There was a problem hiding this comment.
this one tests -01 request with sampled out flag set to 100% of items, so this is intentionally -01
cijothomas
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Activity is recorded, we are going to sample in proactively (i.e. give more weight for these items, see microsoft/ApplicationInsights-dotnet#1200)
When we proactively sample features out, we should check Activity.Recorded first and only sample out those which are not recorded.
Also, I noticed parent -id on requests is not set correctly in W3C format. fixing that.