This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Request tracking improvements #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 5, 2018 20:42
cijothomas
suggested changes
Jul 6, 2018
| @@ -236,14 +252,16 @@ public static IServiceCollection AddApplicationInsightsTelemetryProcessor(this I | |||
| /// <returns> | |||
| /// The <see cref="IServiceCollection"/>. | |||
| /// </returns> | |||
| public static IServiceCollection ConfigureTelemetryModule<T>(this IServiceCollection services, Action<T> configModule) where T : ITelemetryModule | |||
| public static IServiceCollection ConfigureTelemetryModule<T>(this IServiceCollection services, | |||
| Action<T, ApplicationInsightsServiceOptions> configModule) where T : ITelemetryModule | |||
There was a problem hiding this comment.
If we change the signature of this public method, existing customers will break upon upgrading. Can you avoid this breaking change?
There was a problem hiding this comment.
good point, I'll add an overload
lmolkova
commented
Jul 6, 2018
| @@ -393,7 +397,7 @@ public void OnEndRequestFromDifferentInstrumentationKey() | |||
| Assert.True(requestTelemetry.Duration.TotalMilliseconds >= 0); | |||
| Assert.True(requestTelemetry.Success); | |||
| Assert.Equal(CommonMocks.InstrumentationKey, requestTelemetry.Context.InstrumentationKey); | |||
| Assert.Equal("", requestTelemetry.Source); | |||
| Assert.Equal("DIFFERENT_INSTRUMENTATION_KEY_HASH", requestTelemetry.Source); | |||
There was a problem hiding this comment.
this guy was validating the request telemetry without OperationCorrelationTelemetryIntitializer that set Source. Not sure what it was testing though :)
lmolkova
commented
Jul 6, 2018
| public class RequestTrackingTelemetryModuleTest | ||
| { | ||
| [Fact] | ||
| public void RequestTrackingTelemetryModuleDoesNoThrowWhenAppIdProviderisNull() | ||
| { | ||
| RequestTrackingTelemetryModule requestTrackingTelemetryModule = new RequestTrackingTelemetryModule(null); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void RequestTrackingTelemetryModuleDoesNoThrowIfInitializeAfterDispose() |
There was a problem hiding this comment.
I ended up deleting this test, because I don't understand why RequestTrackingTelemetryModule should work after it was disposed. Is there a real-life scenario and why we have such a requirement?
cijothomas
reviewed
Jul 6, 2018
| services.AddSingleton<ITelemetryModule, DependencyTrackingTelemetryModule>(); | ||
| services.ConfigureTelemetryModule<DependencyTrackingTelemetryModule>((module) => { | ||
| services.ConfigureTelemetryModule<DependencyTrackingTelemetryModule>((module, o) => |
There was a problem hiding this comment.
dont need 2nd argument o.
There was a problem hiding this comment.
I marked it as obsolete and want to get rid of it at some point. Do you want to keep it?
cijothomas
reviewed
Jul 6, 2018
| @@ -235,15 +251,37 @@ public static IServiceCollection AddApplicationInsightsTelemetryProcessor(this I | |||
| /// <param name="configModule">Action used to configure the module.</param> | |||
| /// <returns> | |||
| /// The <see cref="IServiceCollection"/>. | |||
| /// </returns> | |||
| /// </returns> | |||
| [Obsolete("Use ConfigureTelemetryModule overaload that accepts ApplicationInsightsServiceOptions.")] | |||
Dmitry-Matveev
approved these changes
Jul 6, 2018
|
@cijothomas ping :) |
SergeyKanzhelev
approved these changes
Jul 10, 2018
cijothomas
approved these changes
Jul 10, 2018
This was referenced Oct 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #709 and #613.
In order to make RequestTrackingTelemetryModule reusable in custom configuration (in particular for Azure Functions) we want to
For significant contributions please make sure you have completed the following items:
Changes in public surface reviewed
Design discussion issue #
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.