Fix issue 488. #490
Fix issue 488. #490
Conversation
Version updates
CHANGELOG.md
Outdated
| - [Support setting request operation name based on executing Razor Page](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/430) | ||
| - [Fixed ITelemetryProcessor dependency injection failure when using 3rd party IoC Container](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/482) | ||
| - Updated SDK version dependency to 2.4.1 for DependencyCollector. | ||
|
|
There was a problem hiding this comment.
Please check the history and add in at least the following items (but with better descriptions than I provided here):
- Updated the ILogger logging of exceptions to send ExceptionTelemetry instead of TraceTelemetry.
- Added sanitization of authenticated user name to the JavaScript snippet output.
- Anything else that changed in develop since 2.1.0.
| @@ -146,6 +146,8 @@ public static IServiceCollection AddApplicationInsightsTelemetry(this IServiceCo | |||
| excludedDomains.Add("core.chinacloudapi.cn"); | |||
| excludedDomains.Add("core.cloudapi.de"); | |||
| excludedDomains.Add("core.usgovcloudapi.net"); | |||
| excludedDomains.Add("localhost"); | |||
| excludedDomains.Add("127.0.0.1"); | |||
There was a problem hiding this comment.
Are we sure we want these always excluded? It was mentioned in the issue that this will break tracking local dependencies when a developer sets up everything on a single machine for local development and testing. I don't think this is something that should be universally forced on everyone. I know a lot of developers used to run a "onebox" with all of their services and databases installed locally when testing a component or service that was part of a larger SOA system. This configuration would exclude tracking such a development setup.
There was a problem hiding this comment.
Yes, this is the same change as made in Web as well. We don't want to break customers by default. Developers using other services in local machine, and remove this to monitor those calls. (not perfect either, but better than the experience of all emulator calls failing by default)
|
Wont merge until functional tests are failed due to this change |
…that correlation headers are injected
And Version updates