Fix Func injection issue on structuremap and track MVC page names #489
Conversation
| @@ -51,9 +52,9 @@ public void Configure(TelemetryConfiguration configuration) | |||
|
|
|||
| if (this.telemetryProcessorFactories.Any()) | |||
| { | |||
| foreach (Func<ITelemetryProcessor, ITelemetryProcessor> processorFactory in this.telemetryProcessorFactories) | |||
| foreach (ITelemetryProcessorFactory processorFactory in this.telemetryProcessorFactories) | |||
There was a problem hiding this comment.
What about existing TelemetryProcessors that were created the old way? This seems like something that should go into 2.2 and not 2.1.1.
There was a problem hiding this comment.
It's not about how TelemetryProcessors were created but how they were registered in DI. Not sure how wide of an adoption this feature got.
There was a problem hiding this comment.
I think @karolz-ms and @pharring are using it.
I agree it is a good change, I just don't think it belongs in this "hotfix" release of bug fixes.
There was a problem hiding this comment.
This will be a small, but breaking change for the exception exemplification feature.
There was a problem hiding this comment.
If this fix is not shipped with AspNetCore 2.0, any application using structure map would be broken because we inject AI everywhere by default.
There was a problem hiding this comment.
@karolz-ms AspNetCore allows usage of third party DI containers if they support common basic set of features. http://structuremap.github.io/ is one of these containers.
There was a problem hiding this comment.
Snapshot Collector ("exception exemplification") doesn't reference this repo. It references the base repo. This won't be a breaking change for us. We'll just have to update our docs.
Instead of injecting
Func<,>factory interface is introduced.OperationName from MVC Razor Page is generated the same way controller/action is makes for simpler code change and consistent behavior.
#482
#430
@dnduffy