Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Reorg: move files from root to NETCORE directory #1015

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Conversation

TimothyMothra
Copy link
Member

microsoft/ApplicationInsights-dotnet#1214

Step 1. Reorganize individual repos. This is to ensure that there are no conflicting directories or file names and to guarantee no conflicts when migrating source. This will require some minor changes to existing build definitions.

Changes

Update Directory

  • EnlistmentRoot stays in root directory
  • Add SourceRoot

@TimothyMothra TimothyMothra marked this pull request as ready for review October 22, 2019 20:25
Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the .vs folder?
That aside, the only change is move entire repo inside NETCORE folder, right?

@@ -0,0 +1,990 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the content of .vs folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's my mistake. the .vs folder was previously in the gitignore, but it doesn't match against the new rule. i'll remove it now. thanks

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps a good time to delete nuget.exe. We just need one in the repo. (checked in binaries is bad practice anyways)

@TimothyMothra
Copy link
Member Author

Let's delete the binaries after the migration as part of the consolidated step.
When I start authoring new build definitions I'll confirm it's not in use.

@TimothyMothra TimothyMothra merged commit a135f1f into develop Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants