2.7.1 Hotfix (#909)

* ApplicationInsights StartupFilter should not swallow exceptions from downstream ApplicationBuilder (#899) * bump to 2.7.1 hotfix
microsoft · Jun 21, 2019 · 05e634b · 05e634b
1 parent 61cb449
commit 05e634b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## Version 2.7.1
+- [Fix - ApplicationInsights StartupFilter should not swallow exceptions from downstream ApplicationBuilder.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/897)
+
 ## Version 2.7.0
  - Updated Web/Base SDK version dependency to 2.10.0
 - [Remove unused reference to System.Net.Http](https://github.com/microsoft/ApplicationInsights-aspnetcore/pull/879)

diff --git a/...crosoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs b/...crosoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs
@@ -23,12 +23,14 @@ public Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next)
                     // via <see cref="TelemetryConfigurationOptionsSetup"/> class which triggers
                     // initialization of TelemetryModules and construction of TelemetryProcessor pipeline.
                     var tc = app.ApplicationServices.GetService<TelemetryConfiguration>();
-                    next(app);
                 }
                 catch (Exception ex)
                 {
                     AspNetCoreEventSource.Instance.LogWarning(ex.Message);
-                }                
+                }
+
+                // Invoking next builder is not wrapped in try catch to ensure any exceptions gets propogated up.
+                next(app);
             };
         }
     }

diff --git a/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj b/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <AssemblyName>Microsoft.ApplicationInsights.AspNetCore</AssemblyName>
-    <VersionPrefix>2.7.0</VersionPrefix>
+    <VersionPrefix>2.7.1</VersionPrefix>
     <Authors>Microsoft</Authors>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <AssemblyTitle>Application Insights for ASP.NET Core Web Applications</AssemblyTitle>