remove ThreadLocal when it's no longer used #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, backoffManager extends ThreadLocal... If we need ThreadLocal in the future, let's opt for field instead of a subclass. |
|
curious why is TLS needed in backoff manager? was this intended or it seems more of bug? |
|
@dhaval24 I think it is needed, but I can't speak to why. When I was running tests in tomcat, there were 5 of these flagged by the leak scanner. So, I assume it's from multiple threads. Regardless, as long as we are using it; it needs to be removed as part of cleanup. |
dhaval24
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this during testing. We should include this in the next release.