Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate Guava #787

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Relocate Guava #787

merged 2 commits into from
Dec 17, 2018

Conversation

dhaval24
Copy link
Contributor

Fix #784

@littleaj I fixed the above. It was quick one liner :)

@dhaval24 dhaval24 added the Bug label Dec 16, 2018
@dhaval24 dhaval24 self-assigned this Dec 16, 2018
@dhaval24 dhaval24 merged commit d898b43 into master Dec 17, 2018
@dhaval24 dhaval24 deleted the fixdependencyreolocation branch December 17, 2018 19:17
littleaj
littleaj reviewed Dec 17, 2018
View reviewed changes
Copy link
Contributor

@littleaj littleaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhaval24 guava needs to be in the whenPomConfigured function

@dhaval24
Copy link
Contributor Author

Thanks @littleaj updating in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littleaj littleaj littleaj left review comments

@lmolkova lmolkova lmolkova approved these changes

Assignees

@dhaval24 dhaval24

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web in release 2.2.1 doesn't relocate guava
3 participants
@dhaval24 @littleaj @lmolkova