-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump errorProneVersion from 2.29.2 to 2.30.0 #3835
Conversation
Bumps `errorProneVersion` from 2.29.2 to 2.30.0. Updates `com.google.errorprone:error_prone_annotations` from 2.29.2 to 2.30.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.29.2...v2.30.0) Updates `com.google.errorprone:error_prone_core` from 2.29.2 to 2.30.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.29.2...v2.30.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_annotations dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.errorprone:error_prone_core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
@@ -44,7 +45,7 @@ public static Map<String, Collection<Object>> fetch( | |||
MBeanServer server = ManagementFactory.getPlatformMBeanServer(); | |||
Set<ObjectName> objects = server.queryNames(new ObjectName(objectName), null); | |||
if (objects.isEmpty()) { | |||
String errorMsg = String.format("Cannot find object name '%s'", objectName); | |||
String errorMsg = String.format(Locale.ROOT, "Cannot find object name '%s'", objectName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi, I usually replace this type of String.format usage with string concatenation, similar to upstream: open-telemetry/opentelemetry-java#4887 (comment)
@@ -115,7 +116,8 @@ private static long getProcessBytes(OSProcess processInfo) { | |||
// use for calculating I/O bytes | |||
private static long getProcessBytesLinux(int processId) { | |||
Map<String, String> io = | |||
FileUtil.getKeyValueMapFromFile(String.format(ProcPath.PID_IO, processId), ":"); | |||
FileUtil.getKeyValueMapFromFile( | |||
String.format(Locale.ROOT, ProcPath.PID_IO, processId), ":"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is better to use string.format. pattern is inside PID_IO constant.
sb.append(String.format(Locale.ROOT, "%02d.", days)); | ||
} | ||
sb.append(String.format("%02d:%02d:%02d", hours, minutes, seconds)); | ||
sb.append(String.format(Locale.ROOT, "%02d:%02d:%02d", hours, minutes, seconds)); | ||
if (milliseconds > 0) { | ||
sb.append(String.format(".%03d0000", milliseconds)); | ||
sb.append(String.format(Locale.ROOT, ".%03d0000", milliseconds)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.. it's better to using string.format to keep number of digits
Bumps
errorProneVersion
from 2.29.2 to 2.30.0.Updates
com.google.errorprone:error_prone_annotations
from 2.29.2 to 2.30.0Release notes
Sourced from com.google.errorprone:error_prone_annotations's releases.
Commits
5ada179
Release Error Prone 2.30.0af175b0
Don't fire theCanIgnoreReturnValueSuggester
for `dagger.producers.Producti...ba8f9a2
Do not update getters that override methods from a superclass.a706e8d
Add ability to suppress warning for the entire AutoValue class86df5cf
Convert some simple blocks to return switches usingyield
474554a
Remove// fall out
comments, which are sometimes used to document an empty ...ac7ebf5
Handlevar
in MustBeClosedCheckerccd3ca6
Add handling of toBuilder()d887307
Omit some unnecessary break statements when translating to->
switchesfe07236
Add Error Prone check for unnecessary boxed types in AutoValue classes.Updates
com.google.errorprone:error_prone_core
from 2.29.2 to 2.30.0Release notes
Sourced from com.google.errorprone:error_prone_core's releases.
Commits
5ada179
Release Error Prone 2.30.0af175b0
Don't fire theCanIgnoreReturnValueSuggester
for `dagger.producers.Producti...ba8f9a2
Do not update getters that override methods from a superclass.a706e8d
Add ability to suppress warning for the entire AutoValue class86df5cf
Convert some simple blocks to return switches usingyield
474554a
Remove// fall out
comments, which are sometimes used to document an empty ...ac7ebf5
Handlevar
in MustBeClosedCheckerccd3ca6
Add handling of toBuilder()d887307
Omit some unnecessary break statements when translating to->
switchesfe07236
Add Error Prone check for unnecessary boxed types in AutoValue classes.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)