Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure-json migration #3790

Merged
merged 27 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
da731ec
Test new exporter with azure-json changes
heyams Jul 20, 2024
8b27764
Update exporter snapshot
heyams Jul 22, 2024
cce5855
Update exporter jar
heyams Jul 24, 2024
1dd63ed
Update exporter jar
heyams Jul 24, 2024
c38c2aa
Merge branch 'main' into heya/azure-json
heyams Jul 24, 2024
96f0cc0
Merge branch 'main' into heya/azure-json
heyams Jul 25, 2024
8ffee4e
Test azure-json 1.2.0
heyams Jul 29, 2024
ee43083
Merge branch 'heya/azure-json' of https://github.com/microsoft/Applic…
heyams Jul 29, 2024
a9d379f
Merge remote-tracking branch 'origin/main' into heya/azure-json
heyams Jul 29, 2024
8fbfcf7
Update deserialization with newline support
heyams Jul 29, 2024
6e81513
Updating the new exporter jar
heyams Jul 30, 2024
89a06dc
Delete the old snapshot
heyams Jul 30, 2024
ce0a257
Lockfile didn't get the new version of azure-json
heyams Jul 30, 2024
b6613bf
Update license to 1.2.0
heyams Jul 30, 2024
8f4ead3
Force azure-json:1.2.0 otherwise it will pick up 1.1.0 by default fro…
heyams Jul 31, 2024
fcf6313
Merge branch 'main' into heya/azure-json
heyams Jul 31, 2024
e36ffd7
Do not add null value into map
heyams Aug 1, 2024
d338279
Merge branch 'main' of https://github.com/microsoft/ApplicationInsigh…
heyams Aug 1, 2024
aaa7366
Merge branch 'heya/azure-json' of https://github.com/microsoft/Applic…
heyams Aug 1, 2024
1bb6c09
Update azure-json exporter snapshot
heyams Aug 2, 2024
d800afa
Merge remote-tracking branch 'origin/main' into heya/azure-json
heyams Aug 7, 2024
320102d
Delete snapshot
heyams Aug 7, 2024
fd9ca11
Update exporter beta.28
heyams Aug 8, 2024
fb55f7f
Merge branch 'main' into heya/azure-json
heyams Aug 8, 2024
648970a
Update
heyams Aug 12, 2024
759641f
Merge branch 'main' of https://github.com/microsoft/ApplicationInsigh…
heyams Aug 12, 2024
ce31eda
Merge branch 'heya/azure-json' of https://github.com/microsoft/Applic…
heyams Aug 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
required: false

env:
EXPORTER_VERSION: 1.0.0-beta.25 # to be updated with the latest version
EXPORTER_VERSION: 1.0.0-beta.28 # to be updated with the latest version

jobs:
spotless:
Expand Down
7 changes: 6 additions & 1 deletion agent/agent-tooling/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies {
implementation(project(":agent:agent-profiler:agent-diagnostics"))
implementation(project(":etw:java"))

implementation("com.azure:azure-monitor-opentelemetry-exporter:1.0.0-beta.26")
implementation("com.azure:azure-monitor-opentelemetry-exporter:1.0.0-beta.28")
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-bootstrap")
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling")
compileOnly("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-servlet-common-bootstrap")
Expand Down Expand Up @@ -87,6 +87,11 @@ dependencies {
testCompileOnly("com.google.code.findbugs:jsr305")
}

configurations.all {
// temporarily overriding version until latest azure-json is part of azure-core
resolutionStrategy.force("com.azure:azure-json:1.2.0")
}

configurations {
"implementation" {
exclude(group = "net.bytebuddy", module = "byte-buddy") // we use byte-buddy-dep
Expand Down
4 changes: 2 additions & 2 deletions agent/agent-tooling/gradle.lockfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ ch.qos.logback:logback-core:1.3.14=runtimeClasspath
com.azure:azure-core-http-netty:1.15.2=runtimeClasspath
com.azure:azure-core:1.50.0=runtimeClasspath
com.azure:azure-identity:1.13.1=runtimeClasspath
com.azure:azure-json:1.1.0=runtimeClasspath
com.azure:azure-monitor-opentelemetry-exporter:1.0.0-beta.26=runtimeClasspath
com.azure:azure-json:1.2.0=runtimeClasspath
com.azure:azure-monitor-opentelemetry-exporter:1.0.0-beta.28=runtimeClasspath
com.azure:azure-sdk-bom:1.2.26=runtimeClasspath
com.azure:azure-storage-blob:12.27.0=runtimeClasspath
com.azure:azure-storage-common:12.26.0=runtimeClasspath
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,18 @@ public Builder setConnectionStrings(@Nullable String connectionString) {
}

public Builder setRoleName(@Nullable String roleName) {
this.roleName = roleName;
globalTags.put(ContextTagKeys.AI_CLOUD_ROLE.toString(), roleName);
if (!Strings.isNullOrEmpty(roleName)) {
this.roleName = roleName;
globalTags.put(ContextTagKeys.AI_CLOUD_ROLE.toString(), roleName);
}
heyams marked this conversation as resolved.
Show resolved Hide resolved
return this;
}

public Builder setRoleInstance(@Nullable String roleInstance) {
this.roleInstance = roleInstance;
globalTags.put(ContextTagKeys.AI_CLOUD_ROLE_INSTANCE.toString(), roleInstance);
if (!Strings.isNullOrEmpty(roleInstance)) {
this.roleInstance = roleInstance;
globalTags.put(ContextTagKeys.AI_CLOUD_ROLE_INSTANCE.toString(), roleInstance);
}
return this;
}

Expand Down
2 changes: 2 additions & 0 deletions agent/agent/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -226,5 +226,7 @@ configurations {
// excluding unused dependencies for size (~1.8mb)
exclude("com.fasterxml.jackson.dataformat", "jackson-dataformat-xml")
exclude("com.fasterxml.woodstox", "woodstox-core")
// temporarily overriding version until latest azure-json is part of azure-core
resolutionStrategy.force("com.azure:azure-json:1.2.0")
}
}
6 changes: 3 additions & 3 deletions licenses/more-licenses.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

# agent
## Dependency License Report
_2024-08-07 03:28:41 UTC_
_2024-08-08 16:29:35 PDT_
## Apache License, Version 2.0

**1** **Group:** `com.fasterxml.jackson.core` **Name:** `jackson-annotations` **Version:** `2.17.2`
Expand Down Expand Up @@ -358,11 +358,11 @@ _2024-08-07 03:28:41 UTC_
> - **POM Project URL**: [https://github.com/Azure/azure-sdk-for-java](https://github.com/Azure/azure-sdk-for-java)
> - **POM License**: MIT License - [https://opensource.org/licenses/MIT](https://opensource.org/licenses/MIT)

**69** **Group:** `com.azure` **Name:** `azure-json` **Version:** `1.1.0`
**69** **Group:** `com.azure` **Name:** `azure-json` **Version:** `1.2.0`
> - **POM Project URL**: [https://github.com/Azure/azure-sdk-for-java](https://github.com/Azure/azure-sdk-for-java)
> - **POM License**: MIT License - [https://opensource.org/licenses/MIT](https://opensource.org/licenses/MIT)

**70** **Group:** `com.azure` **Name:** `azure-monitor-opentelemetry-exporter` **Version:** `1.0.0-beta.26`
**70** **Group:** `com.azure` **Name:** `azure-monitor-opentelemetry-exporter` **Version:** `1.0.0-beta.28`
> - **POM License**: MIT License - [https://opensource.org/licenses/MIT](https://opensource.org/licenses/MIT)

**71** **Group:** `com.azure` **Name:** `azure-storage-blob` **Version:** `12.27.0`
Expand Down
Loading