-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMX Metrics to OTLP & Breeze #3406
Merged
Merged
Changes from 19 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
3bc5624
experimental changes
harsimar 85867db
modifying dotinjmxmetric test to use mock breeze and otlp, with a mod…
harsimar 1b65c2d
adding thread count metric
harsimar 84afc02
rename and refactor test based on helen's most recent otlp test pr
harsimar 22324ff
pull from upstream and fix merge conflict
harsimar c189821
removing metricItems list size assertion because it is sometimes 4 in…
harsimar f92231a
partial restructuring changes, will complete tomorrow
harsimar 6791fc8
restructuring done, figure out why the callback is being called 2x pe…
harsimar 48e6123
minor, may remove some logging later
harsimar e7ed384
some cleanup and test changes, need to still add check for timestamp
harsimar e9314e9
adding more test cases
harsimar 1a0320a
fixing tests and cleanup code
harsimar 6136ac2
Merge branch 'main' into harskaur/jmkMetricsToOtlp
harsimar 3720c17
fixing spotless violations
harsimar 3590e55
more spotless apply
harsimar 1427b4e
Fix unexpected metrics smoke test
heyams 1f5d56a
adding schema url to meter and pr comments
harsimar fd4aedd
spotless
harsimar 5640a81
pr comments
harsimar 4c590d4
changed character replace regex
harsimar e6af6c7
removing schema url & pr comments
harsimar 5499b39
adding attribute
harsimar 3240814
spotless apply
harsimar 375b36b
rename attribute
harsimar ea5787f
spotless
harsimar 39b0932
Update internal metric name
heyams 09edf1d
Merge branch 'main' into harskaur/jmkMetricsToOtlp
heyams 3ca9581
Update license
heyams c7e5977
Merge branch 'harskaur/jmkMetricsToOtlp' of https://github.com/harsim…
heyams 007b387
Update test
heyams 9eebc69
Delete unused import
heyams 18a1e92
Fix test
heyams ea6be27
Fix ambiguous assertion
heyams ec303ac
Keep old metric name for breeze endpoint
heyams c8cadb3
Fix smoke test
heyams 9d21009
Merge branch 'main' into harskaur/jmkMetricsToOtlp
heyams d500a7f
Fix flaky tests
heyams 3c5c04c
Fix flaky tests
heyams cb3b5f2
Merge branch 'harskaur/jmkMetricsToOtlp' of https://github.com/harsim…
heyams 2c56a3e
Fix conconurrent CI tests sharing the same SET
heyams 15ca137
Create constants
heyams fd95eaf
my intended formatting of this comment
harsimar 573523a
Fix spotless
heyams d498d7d
Remove unnecessary outer try/catch block
heyams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 0 additions & 68 deletions
68
...ic/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/DotInJmxMetricTest.java
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
smoke-tests/apps/DotInJmxMetric/src/smokeTest/resources/applicationinsights.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like previously we had try/catch around each JMX metric, which could be better since then a single JMX metric problem wouldn't affect the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is another try block above.