Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-monitor-opentelemetry-exporter #3356

Merged
merged 24 commits into from
Oct 26, 2023
Merged

Update azure-monitor-opentelemetry-exporter #3356

merged 24 commits into from
Oct 26, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Oct 23, 2023

No description provided.

@heyams heyams changed the title Update azure-monitor-opentelemetry-exporter to beta.12 Update azure-monitor-opentelemetry-exporter Oct 25, 2023
@heyams heyams marked this pull request as ready for review October 25, 2023 23:15
@heyams heyams requested a review from ramthi as a code owner October 25, 2023 23:15
featureList.add(Feature.PREVIEW_DISK_PERSISTENCE_MAX_SIZE_MB);
}
if (!config.preview.useNormalizedValueForNonNormalizedCpuPercentage) {
featureList.add(Feature.PREVIEW_DONT_USE_NORMALIZED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I think I was too brief on my prior comment, we should probably make this a bit clearer (longer 😅), but can do that later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a way to identify the preview feature. do you prefer PREVIEW_DONT_USE_NORMALIZED_VALUE_FOR_NON_NORMALIZED_CPU_PERCENTAGE because of the negation?
this is even longer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, it's the negation that I was commenting on

maybe PREVIEW_REPORT_NON_NORMALIZED_CPU_PERCENTAGE

since essentially this setting opts in to (correctly) reporting the non-normalized cpu percentage (we're only not enabling it by default yet due to it being a breaking change)

@heyams heyams merged commit e58f62f into main Oct 26, 2023
84 checks passed
@heyams heyams deleted the heya/dev branch October 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants