New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply exception type and message #3148

Merged

heyams merged 12 commits into main from heya/fix-exception.type-and-message

Jul 6, 2023

Contributor

heyams commented Jun 20, 2023 •

edited

Loading

testing is done here


          Inherite exception type and message

b7ae9a6

heyams requested review from jeanbisutti, ramthi and trask as code owners

June 20, 2023 18:37

jeanbisutti reviewed

View reviewed changes

Member

jeanbisutti left a comment •

edited

Loading

Could you add automatic assertions on the new behavior?

Contributor Author

heyams commented Jun 21, 2023

smoke test didn't work. i'll wait for trask's feedback then.

Contributor Author

heyams commented Jun 23, 2023

note: customer is happy with this fix.

trask reviewed

View reviewed changes

...rc/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentLogExporter.java Outdated Show resolved Hide resolved

trask reviewed

View reviewed changes

...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java Outdated Show resolved Hide resolved

trask reviewed

View reviewed changes

...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java Outdated Show resolved Hide resolved

heyams added 2 commits

June 27, 2023 13:41


          Address comments

2d66e97


          Add smoke test

5445ae1

Contributor Author

heyams commented Jun 27, 2023

@trask added smoke test, please check it out

trask reviewed

View reviewed changes

...piLogBridge/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java Outdated Show resolved Hide resolved

trask reviewed

View reviewed changes

...piLogBridge/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java Outdated Show resolved Hide resolved

heyams added 2 commits

June 27, 2023 14:49


          Address comments

a6ccd94


          Fix spotless

ff0c130

trask reviewed

View reviewed changes

...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java Show resolved Hide resolved

trask reviewed

View reviewed changes

...mokeTest/java/com/microsoft/applicationinsights/smoketest/OpenTelemetryApiLogBridgeTest.java Show resolved Hide resolved

Contributor Author

heyams commented Jul 5, 2023

have you checked out the smoke test? what is the risk of not having smoke test for this?

trask and others added 5 commits

July 5, 2023 14:02


          Merge remote-tracking branch 'origin/main' into heya/fix-exception.ty…

84707e9

…pe-and-message


          Fix module name

af58145


          Add assertion

c319e26

Fix

39852f0


          Comments

e058209

trask reviewed

View reviewed changes

...rc/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentLogExporter.java Outdated Show resolved Hide resolved

trask approved these changes

View reviewed changes

heyams added 2 commits

July 6, 2023 11:24

Fix

fc492de


          Fix spotbug

784bcf8

heyams merged commit fc9b26c into main

84 checks passed

heyams deleted the heya/fix-exception.type-and-message branch

July 6, 2023 19:09

ivan-zaitsev mentioned this pull request

Not all exceptions are populated with exception type and message #3739

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet