Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider 4xx and 5xx as failures #295

Merged
merged 1 commit into from
Jul 29, 2016
Merged

Consider 4xx and 5xx as failures #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...soft/applicationinsights/web/extensibility/modules/WebRequestTrackingTelemetryModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public void onEndRequest(ServletRequest req, ServletResponse res) {

ApplicationInsightsHttpResponseWrapper response = ((ApplicationInsightsHttpResponseWrapper)res);
if (response != null) {
telemetry.setSuccess(response.getStatus() >= 200 && response.getStatus() < 300);
telemetry.setSuccess(response.getStatus() < 400);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
I see the .NET SDK also treat 401 as success

Please keep the same behavior so the SDKs are aligned. Thanks.

telemetry.setResponseCode(Integer.toString(response.getStatus()));
} else {
InternalLogger.INSTANCE.error("Failed to get response status for request ID: %s", telemetry.getId());
Expand Down