Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set resultCode to zero when Span.httpStatusCode is not present #2925

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Set resultCode to zero when Span.httpStatusCode is not present #2925

merged 2 commits into from
Feb 22, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Feb 21, 2023

@heyams heyams changed the title Set resultCode to zero when it's not present Set resultCode to zero when Span.httpStatusCode is not present Feb 21, 2023
@trask trask merged commit 4341890 into main Feb 22, 2023
@trask trask deleted the heya/result-code branch February 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyams @trask @jeanbisutti